Page 1 of 1

[SOLVED] MX-17 package update request: Xfburn

Posted: Fri Jul 27, 2018 11:02 am
by MX-16_fan
I have been advised to use Xfburn instead of Brasero (https://forum.mxlinux.org/viewtopic.php ... 08#p455808).

Unfortunately using Xfburn's 0.5.4 version that ships with MX-17 (from Debian) is extremely difficult for me: Xfburn's window is about twice as wide as my acual screen, and the window can't be rescaled. This is the only application that has shown this kind of behaviour so far.

The most current stable version of Xfburn seems to be 0.5.5. According to this changelog: https://launchpad.net/ubuntu/+source/xfburn/0.5.5-1, "some fixes for the desktop file" have been implemented there, so maybe that fixes the problem.

I see that 0.5.5 is available in Debian Sid (https://packages.debian.org/en/sid/xfce/xfburn). Could you possibly provide it in the MX Test Repo?


Greetings, and thanks so much in advance for looking into this, Joe

Re: MX-17 package update request: Xfburn

Posted: Fri Jul 27, 2018 11:15 am
by chrispop99
Might it be better to try to fix the re-sizing problem first; it's possible it may still happen with the updated version?

Xfburn has never exhibited that behaviour here when testing, although on my everyday machine I use K3B.

Chris

Re: MX-17 package update request: Xfburn

Posted: Fri Jul 27, 2018 12:07 pm
by fehlix
MX-16_fan wrote: Fri Jul 27, 2018 11:02 am ...
Unfortunately using Xfburn's 0.5.4 version that ships with MX-17 (from Debian) is extremely difficult for me: Xfburn's window is about twice as wide as my acual screen, and the window can't be rescaled.
This is the only application that has shown this kind of behaviour so far.
...
Seems to be a translation-string related issue with to long translated / unwrapped strings.
Please try to use default build in locale (english)
by starting from the cli or by adjusting the desktop starter accordingly
like this:

Code: Select all

env LANG=C xfburn

Re: MX-17 package update request: Xfburn

Posted: Fri Jul 27, 2018 12:51 pm
by MX-16_fan
@fehlix:
fehlix wrote: Fri Jul 27, 2018 12:07 pm (...)
Seems to be a translation-string related issue with to long translated / unwrapped strings.
Please try to use default build in locale (english)
by starting from the cli or by adjusting the desktop starter accordingly
like this:

Code: Select all

env LANG=C xfburn
Thanks for the workaround. With that I get a normal width.

Is that an error in the 0.5.4 source code?


Greetings, Joe

Re: MX-17 package update request: Xfburn

Posted: Fri Jul 27, 2018 1:02 pm
by fehlix
MX-16_fan wrote: Fri Jul 27, 2018 12:51 pm @fehlix:
fehlix wrote: Fri Jul 27, 2018 12:07 pm (...)
Seems to be a translation-string related issue with to long translated / unwrapped strings.
Please try to use default build in locale (english)
by starting from the cli or by adjusting the desktop starter accordingly
like this:

Code: Select all

env LANG=C xfburn
Thanks for the workaround. With that I get a normal width.

Is that an error in the 0.5.4 source code?


Greetings, Joe
I would flag it a an translation code error, as the translation string missing line feeds for line wrappings.
So in this sense as the translation strings are part of the souce code package you can regard it as a source code "bug" ;)

Re: MX-17 package update request: Xfburn

Posted: Fri Jul 27, 2018 2:13 pm
by Stevo
That's something which we should be able to fix in a patch for the affected translation file if necessary. I'll backport 5.5 to see if they've fixed it, and if not, we can work to fix the string in the localization source file...though upstream should also be notified of the bug. Is it in the "de" locale?

Re: MX-17 package update request: Xfburn

Posted: Fri Jul 27, 2018 3:09 pm
by MX-16_fan
@Stevo:
Stevo wrote: Fri Jul 27, 2018 2:13 pm That's something which we should be able to fix in a patch for the affected translation file if necessary. I'll backport 5.5 to see if they've fixed it, and if not, we can work to fix the string in the localization source file...though upstream should also be notified of the bug.
Thanks!
Stevo wrote: Fri Jul 27, 2018 2:13 pm Is it in the "de" locale?
Yes.


Greetings, and have a great weekend, Joe

Re: MX-17 package update request: Xfburn

Posted: Fri Jul 27, 2018 3:21 pm
by Stevo
I can't see any fix Debian added for the 0.5.5 version, no Debian bug reports for the issue: https://bugs.debian.org/cgi-bin/pkgrepo ... t=unstable and there's no change at all in the de translation source file between 0.5.4 and 0.5.5. I can see some sections where it looks like the de translation strings are missing the returns, so I'll try and fix those.

Re: MX-17 package update request: Xfburn

Posted: Fri Jul 27, 2018 4:21 pm
by fehlix
Stevo wrote: Fri Jul 27, 2018 3:21 pm I can't see any fix Debian added for the 0.5.5 version, no Debian bug reports for the issue: https://bugs.debian.org/cgi-bin/pkgrepo ... t=unstable and there's no change at all in the de translation source file between 0.5.4 and 0.5.5. I can see some sections where it looks like the de translation strings are missing the returns, so I'll try and fix those.
Changing the strings below within xfburn.mo for locale DE

Code: Select all

--- xfburn.po.orig	2018-07-27 20:54:43.579202403 +0200
+++ xfburn.po	2018-07-27 21:44:02.265074643 +0200
@@ -162,7 +162,7 @@
 msgstr "Künstler"
 
 msgid "Audio CD playable in regular stereos"
-msgstr "Eine Musik-CD zum Abspielen in normalen Stereoanlagen erstellen"
+msgstr "Eine Musik-CD zum Abspielen\nin normalen Stereoanlagen erstellen"
 
 msgid "Audio composition"
 msgstr "Musikzusammenstellung"
@@ -195,7 +195,7 @@
 msgstr "CD-Abbild brennen (xfburn)"
 
 msgid "Burn a prepared compilation, i.e. an .ISO file"
-msgstr "Zusammenstellung brennen (z.B. ISO-Dateien)"
+msgstr "Zusammenstellung brennen\n   (z.B. ISO-Dateien)"
 
 msgid "Burn image"
 msgstr "Abbild brennen"
@@ -360,7 +360,7 @@
 msgstr "ISO aus CD erzeugen"
 
 msgid "Create a new data disc with the files of your choosing"
-msgstr "Ein neues Datenmedium mit beliebigen Dateien erstellen"
+msgstr "Ein neues Datenmedium\nmit beliebigen Dateien erstellen"
 
 msgid "Create directory"
 msgstr "Neuer Ordner"
@@ -667,7 +667,7 @@
 
 msgid "Prepare the rewriteable disc for a new burn"
 msgstr ""
-"Ein wiederbeschreibbares (RW) Medium für einen neuen Brennvorgang vorbereiten"
+"Ein wiederbeschreibbares (RW) Medium\nfür einen neuen Brennvorgang vorbereiten"
 
 msgid "Proceed to Burn"
 msgstr "Weiter zum Brennen"
gives me those minimal window of the start screen in comparison for the orignal one

Re: MX-17 package update request: Xfburn

Posted: Fri Jul 27, 2018 4:23 pm
by Stevo
Hmmm...I did a bigger set of changes.

Does this version fix it?

https://drive.google.com/open?id=1FxCv9 ... 4KnDGr7WWJ

Re: MX-17 package update request: Xfburn

Posted: Fri Jul 27, 2018 4:36 pm
by fehlix
Stevo wrote: Fri Jul 27, 2018 4:23 pm Hmmm...I did a bigger set of changes.

Does this version fix it?

https://drive.google.com/open?id=1FxCv9 ... 4KnDGr7WWJ
Not realy: I do not see a difference in the start screen, which is the main show stopper.
xfburn-0.5.5-stevo1.png
The upper picture is live running your version.
below the screen dump of the orignal unpatched and my pachtched version.

Re: MX-17 package update request: Xfburn

Posted: Fri Jul 27, 2018 4:41 pm
by entropyfoe
Steveo,

Wow you are an expert, able to dig into the debian stuff and the translation strings.

This is what powers MX linux above and beyond many distros.
(like one earlier poster...I to am a k3b guy)
Thanks :cool:

Re: MX-17 package update request: Xfburn

Posted: Fri Jul 27, 2018 5:25 pm
by Stevo
The Debian maintainers are far more expert; I'm just wading where they are Olympic-class swimmers.

OK, try this rebuild:

https://drive.google.com/open?id=1EyQmC ... gXhdAgKh96

Re: MX-17 package update request: Xfburn

Posted: Fri Jul 27, 2018 5:44 pm
by fehlix
Stevo wrote: Fri Jul 27, 2018 5:25 pm The Debian maintainers are far more expert; I'm just wading where they are Olympic-class swimmers.

OK, try this rebuild:
Looks good:
xfburn-0.5.5-try2.png

Re: MX-17 package update request: Xfburn

Posted: Fri Jul 27, 2018 6:37 pm
by Stevo
fehlix wrote: Fri Jul 27, 2018 5:44 pm
Stevo wrote: Fri Jul 27, 2018 5:25 pm The Debian maintainers are far more expert; I'm just wading where they are Olympic-class swimmers.

OK, try this rebuild:
Looks good:
xfburn-0.5.5-try2.png

OK, will send it up. I couldn't use your patch as is, since the source has no xfburn.po file, so I just made the same changes to the /po/de.po file in the source. I suppose the Debian developers all have fancy hdpi screens and don't see any problem with the widescreen version they have.

Re: MX-17 package update request: Xfburn

Posted: Fri Jul 27, 2018 6:41 pm
by fehlix
Stevo wrote: Fri Jul 27, 2018 6:37 pm OK, will send it up. I couldn't use your patch as is, since the source has no xfburn.po file, so I just made the same changes to the /po/de.po file in the source. I suppose the Debian developers all have fancy hdpi screens and don't see any problem with the widescreen version they have.
Thanks Stevo.

Re: MX-17 package update request: Xfburn

Posted: Sun Jul 29, 2018 11:09 am
by MX-16_fan
@Stevo:
Stevo wrote: Fri Jul 27, 2018 4:23 pm (...) Does this version fix it?

https://drive.google.com/open?id=1FxCv9 ... 4KnDGr7WWJ
Thanks! Just tried it out. Takes very long to start (about 20 seconds), and unfortunately the window still has about 35% too much in width (which, however, is, as far as I remember, less too much than with the 0.5.4 version).

Before installation, Lintian complained:
W: xfburn: latest-debian-changelog-entry-without-new-version
N: 1 tag overridden (1 warning)

Lintian finished with exit status 0
What does that mean?


Greetings, Joe

Re: MX-17 package update request: Xfburn

Posted: Sun Jul 29, 2018 11:40 am
by fehlix
you need read two posts further down :p
+++
EDIT:
and you might just install the final fixed version 0.5.5-1~mx17+1 from with MXPI:

Code: Select all

LANG=C apt policy xfburn
xfburn:
  Installed: 0.5.5-1~mx17+1
  Candidate: 0.5.5-1~mx17+1
  Version table:
 *** 0.5.5-1~mx17+1 500
        500 https://ftp.fau.de/mxlinux-packages/mx/repo stretch/main amd64 Packages
        100 /var/lib/dpkg/status
     0.5.4-1 500
        500 http://ftp.de.debian.org/debian stretch/main amd64 Packages

Re: MX-17 package update request: Xfburn

Posted: Sun Jul 29, 2018 11:57 am
by MX-16_fan
@fehlix:
fehlix wrote: Sun Jul 29, 2018 11:40 am you need read two posts further down :p
(...)
Thanks!



@Stevo:

Installs without issues and starts at a normal speed. This version resolves the window issue.

O.k. to mark this "SOLVED"? Or do you want me to wait until some more people have tested this version?

Thanks so much for this important fix! Do you have any means of reporting this to upstream?


Greetings, Joe

Re: MX-17 package update request: Xfburn

Posted: Sun Jul 29, 2018 4:08 pm
by Stevo
I don't know if the other languages are affected, but the best way for German is to update the translation in the xfburn upstream source, whatever way they have set up to contribute--I think they have some git setup where the patch could be pushed up.. Debian also has a bug reporting setup, but any fixes usually just trickle down to the next release, instead of for stable users.

Re: MX-17 package update request: Xfburn

Posted: Mon Jul 30, 2018 4:54 pm
by MX-16_fan
@scdbackup:

Do you happen to have a bug reporting account that would be suitable for notifying upstream about the great fix which @Stevo has worked out?


Greetings, Joe

Re: MX-17 package update request: Xfburn

Posted: Mon Jul 30, 2018 5:03 pm
by Stevo
It looks like it has a mirror on github:

https://github.com/xfce-mirror/xfburn

Re: MX-17 package update request: Xfburn

Posted: Mon Jul 30, 2018 5:48 pm
by fehlix
Stevo wrote: Mon Jul 30, 2018 5:03 pm It looks like it has a mirror on github:

https://github.com/xfce-mirror/xfburn
Thanks, Stevo. I'll have a look to fix this long-string issues there. :bagoverhead:

Re: MX-17 package update request: Xfburn

Posted: Sat Aug 11, 2018 5:05 am
by MX-16_fan
@fehlix:
fehlix wrote: Mon Jul 30, 2018 5:48 pm(...) I'll have a look to fix this long-string issues there ... .
Thanks for your announcement to get the fix into upstream's code :happy:.

Did getting this into GitHub work out for you? Just asking because I can't see any commit in https://github.com/xfce-mirror/xfburn/tree/xfburn-0.5.5 since December 14th, 2017.

I'd mark this thread here "SOLVED" as soon as I know that Stevo's fix is in upstream.


Greetings, and have a great weekend, Joe

Re: MX-17 package update request: Xfburn

Posted: Sat Aug 11, 2018 11:09 am
by fehlix
MX-16_fan wrote: Sat Aug 11, 2018 5:05 am ...I'd mark this thread here "SOLVED" as soon as I know that Stevo's fix is in upstream.
You might consider to request this change yourself upstream. This would provide you better position to monitor when this fix is applied at github.

Re: MX-17 package update request: Xfburn

Posted: Sat Aug 11, 2018 11:42 am
by scdbackup
Hi,

sorry, i am not affiliated with Xfburn other than being provider of
the libraries libburn and libisofs. My last attempt to contact David
Mohr is a while ago. He might have retired from the project.

But look at https://git.xfce.org/apps/xfburn/log/
There are commit messages not older than 10 days.
Interesting seems to be this header line in each commit:

committer Transifex <noreply@xfce.org>

https://www.transifex.com/blog/2010/xfc ... transifex/ says
"In case you’ve missed it, the Xfce project has been using their
own installation of Transifex to manage their translations online!
Translators can now visit http://translations.xfce.org and keep up
with the action!"

Have a nice day :)

Thomas

Re: MX-17 package update request: Xfburn

Posted: Sat Aug 11, 2018 11:57 am
by fehlix
scdbackup wrote: Sat Aug 11, 2018 11:42 am ...https://www.transifex.com/blog/2010/xfc ... transifex/ says
"In case you’ve missed it, the Xfce project has been using their
own installation of Transifex to manage their translations online!
Translators can now visit http://translations.xfce.org and keep up
with the action!"
@scdbackup, thanks, that was a good hint.

Re: MX-17 package update request: Xfburn

Posted: Sat Aug 11, 2018 12:00 pm
by MX-16_fan
@scdbackup:

Thanks!


@Stevo:
scdbackup wrote: Sat Aug 11, 2018 11:42 am (...) https://www.transifex.com/blog/2010/xfc ... transifex/ says
"In case you’ve missed it, the Xfce project has been using their
own installation of Transifex to manage their translations online!
Translators can now visit http://translations.xfce.org and keep up
with the action!" (...)
Stevo, is your fix a fix to the PO file? If so, I could try to work out how to commit your fix to Transifex.

Would be a some kind of waste if it never got upstream.


Greetings, Joe

Re: MX-17 package update request: Xfburn

Posted: Sat Aug 11, 2018 12:26 pm
by fehlix
MX-16_fan wrote: Sat Aug 11, 2018 12:00 pm Stevo, is your fix a fix to the PO file? If so, I could try to work out how to commit your fix to Transifex.
@MX-16_fan , yes you can do it yourself, just register with xfce's transiflex
and enter the correct translations, which have been already fixed for you
with Stevo's and my help. ( see the fixed translation above within this thread)
The PO files and diff shown above will help you how to change the translations.
:puppy:

Re: MX-17 package update request: Xfburn

Posted: Thu Jul 16, 2020 11:07 pm
by Stevo
A patched MX 19 build of 0.5.5 should be in main shortly, as well as 0.6.2 with a refreshed patch in the MX 19 test repo.

Re: MX-17 package update request: Xfburn

Posted: Mon Aug 10, 2020 3:24 pm
by MX-16_fan
@Stevo:
Stevo wrote: Thu Jul 16, 2020 11:07 pm A patched MX 19 build of 0.5.5 should be in main shortly, as well as 0.6.2 with a refreshed patch in the MX 19 test repo.
Thanks so much, Stevo :number1:!


@chrispop99,
@fehlix,
@scdbackup:

Thanks so much for helping debugging the window issue here!


@all:

As this was a mere package update request, and the package has been updated, I'll mark this thread "SOLVED". In case there are any further issues, they will go into a separate thread which would then relate to the new version(s).



Greetings, and a good week to all of you :happy:, Joe