Page 1 of 1

Settings: Keybindings

Posted: Wed Sep 06, 2023 3:22 pm
by Jerry3904
This one has been on my list for a month, figure it's time to take a look at it.

==========

I had an interesting comment on my vid "Here comes MX-23 Fluxbox":
IMHO best have a launcher on the panel to a pic/ image or even text file with the fluxkey combinations.
I answered that I thought the way to treat it was to put it into the Settings dashboard, and he agreed. I'd be interested in thoughts on what and how that item should be like.

WHAT
Being a lazy bum, I think the easiest way to start with this is to use the fluxbox conky, since we had thought carefully about what to include. So I took the conky text, stripped out the code and edited a bit to produce this (--> attached).
COMMON FLUXBOX KEYBINDINGS

MX-Help/Manual/Tools
help: Ctrl F1 manual: Shift F1
tools: Ctrl F5 screen magnifier: Ctrl Mod1 m

Programs
all apps: Left logo
run: Ctrl F2
file manager: Ctrl F3
screen grab: Print OR Alt q
terminal: Ctrl Alt t dropdown: Ctrl F4

Volume
volume +/-: Ctrl 

Switch Workspaces
next: Scroll wheel up OR Ctrl Alt 
prev: Scroll wheel down OR Ctrl Alt 

Windows
min: Alt F9 max: Alt F10 close: Alt F4
move: Alt Left click resize: Alt Right Click
show desktop: Alt d hide menus: Left click
workspace menu: Middle click
fluxbox menu: Right click

Tiling
1/2: Ctrl 1-4 OR Alt KP-2,4,6,8
1/4: Ctrl 5-8 OR Alt KP-1,3,7,9
1/3 left: Ctrl 9 center: Alt KP-5
fullscreen: Ctrl 0

Details and other bindings in $HOME/.fluxbox/keys
That needs obvious expansion and clarification, but it seems to me a good basic document already.

HOW
What format would we want to use?

--Text file
--PDF
--HTML using mxviewer << translation difficult unless we put it in the WIki and let Google do its *automagic*
--Image << Could be very effective but translation becomes an issue

(ICON: keys over MXFB logo?)

==========

Thoughts?

Re: Settings: Keybindings

Posted: Thu Sep 07, 2023 6:03 am
by Melber
Something based on

Code: Select all

yad --text-info < keybindings_LANG.txt
perhaps?

Could have an edit button to open the keys file itself.


First idea for papirus styled icon
mxfb-keybindings.png
or in burnt orange
mxfb-keybindings-2.png

Re: Settings: Keybindings

Posted: Thu Sep 07, 2023 5:08 pm
by Melber
@Jerry3904 I forgot text-info doesn't allow formatting...

230907_keybindings.png

To test: unpack archive into ~/Documents und run mxfb-keybindings from there.
(nb. if your system language is not English you need to edit FILEPATH=$HOME/Documents/keybindings in the script to match your system)

+++updated tar+++
keybindings.tar

Re: Settings: Keybindings

Posted: Thu Sep 07, 2023 5:46 pm
by Jerry3904
(Pretty sure he means: "if your system language is not German...")

It launches fine--thanks. Will look more closely tomorrow--into wine with wife.

Re: Settings: Keybindings

Posted: Thu Sep 07, 2023 6:20 pm
by Melber
No, he meant "if your system language is not English", but he's an idiot and included the wrong script...

I've swapped out the tar file in post #3 with the correct version.

Re: Settings: Keybindings

Posted: Thu Sep 07, 2023 6:40 pm
by Jerry3904
Ha!

Re: Settings: Keybindings

Posted: Thu Sep 07, 2023 7:31 pm
by Melber
and yes, I know it's kinda dumb to put it in Documents but I just threw together a quick test to see if it worked.
I will adjust the paths to something sensible if this goes any further...

Btw, the script should pick up non-english system languages if you do the following:
- create a folder named with the lower case two letter language code in ~/Documents/keybindings (ie. a folder named "de" for German or "pl" for Polish etc)
- save a copy of keybindings.txt in this language folder
- translate the copied text file and save
- run the script and you should see the translated list

Re: Settings: Keybindings

Posted: Thu Sep 07, 2023 7:44 pm
by Jerry3904
Thanks.

Re: Settings: Keybindings

Posted: Fri Sep 08, 2023 8:51 am
by Jerry3904
I'm sorry, but that is so ugly that I'm looking at an alternative. Check this LO table, for instance, that I have only half finished; need to fill in rest of keys, color-code modifiers, etc.. Could be used as a PDF, image, etc.

Re: Settings: Keybindings

Posted: Fri Sep 08, 2023 9:10 am
by Jerry3904
Just as a test, I ran it through DeepL as a PDF -- BTW, DeepL now allows us with our Pro account to download that as a Word doc, suggesting the option of providing that so the user could change to individual settings, maybe with a button to edit on the GUI (?)

Re: Settings: Keybindings

Posted: Fri Sep 08, 2023 11:52 am
by Melber
Jerry3904 wrote: Fri Sep 08, 2023 8:51 am I'm sorry, but that is so image is so ugly that I'm looking at an alternative. Check this LO table, for instance, that I have only half finished; need to fill in rest of keys, color-code modifiers, etc.. Could be used as a PDF, image, etc.
Changing the font from monospace to something else won't rescue it?

OK, no problem, eye of the beholder...I personally have issues with serif fonts, wrong way round side labels and uneven column widths ;)

Undecided what the best format is.
Not so sold on the idea of using pdf/image files. Presuming the aim is that, once finalised, the list won't be changed too often, but if it does need to be updated somebody then needs to go through and create new pdfs/images for all the translations.
If it's just a text file, what's the advantage over just opening the keys file directly?

Maybe I could look at making a yad form to get it looking table like...

Jerry3904 wrote: Fri Sep 08, 2023 9:10 am Just as a test, I ran it through DeepL as a PDF -- BTW, DeepL now allows us with our Pro account to download that as a Word doc, suggesting the option of providing that so the user could change to individual settings, maybe with a button to edit on the GUI (?)
Needs to be editable, there's stuff in there that needs to be corrected, eg. Press != Presse in this context, Print Key != Taste drucken, Windows not translated...somebody is going to have to go over the translations to at least correct the nonsensical stuff.

Re: Settings: Keybindings

Posted: Fri Sep 08, 2023 12:40 pm
by Jerry3904
OK, no problem, eye of the beholder...I personally have issues with serif fonts, wrong way round side labels and uneven column widths ;)
Fonts and widths easy to change, I like the labels but...
Not so sold on the idea of using pdf/image files. Presuming the aim is that, once finalised, the list won't be changed too often, but if it does need to be updated somebody then needs to go through and create new pdfs/images for all the translations.
True, but I personally don't foresee a need for our changing these common bindings
If it's just a text file, what's the advantage over just opening the keys file directly?
Because it's nearly unreadable for a new user!

Anyway, it's just an idea. If anyone wants to play around, I've attached the completed draft.

Re: Settings: Keybindings

Posted: Sat Sep 09, 2023 9:00 am
by Jerry3904
Saturday morning and a lot of coffee have produced another ("just an") idea:
--top: "This tool provides convenient access to keyboard shortcuts, called "keys" in Fluxbox."
--Button 1: "View commonly used shortcuts"
--Button 2: "View or edit the config file"
--Help: maybe a short dedicated vid?
I'm done.

Re: Settings: Keybindings

Posted: Sat Sep 09, 2023 11:29 am
by siamhie
Jerry3904 wrote: Wed Sep 06, 2023 3:22 pm
IMHO best have a launcher on the panel to a pic/ image or even text file with the fluxkey combinations.

Couldn't the user just add an entry to the tint2 panel to open the keys file? I quickly threw this together and it seems to work.

Found an icon that closely represents key-bindings.
key-binding.png


Then opened tint2 settings and added a button. Now when I click on the button it opens the fluxbox keys file.
Image


Just thinking out loud.

Re: Settings: Keybindings

Posted: Sat Sep 09, 2023 12:23 pm
by Jerry3904
Sure. But as I wrote in the top post in this thread: 1) we like to keep the default panel uncluttered, and 2) the keys file is not an easy read.

This thread is about the "what and how" of a user-friendly app into the Settings dashboard...

Re: Settings: Keybindings

Posted: Sat Sep 09, 2023 12:56 pm
by Melber
@Jerry3904
next attempt with yad...this time as a form with side tabs
230909-keybindings.png
Still too ugly?
(nb. text formatting will vary a bit depending on font style and size)

Script attached if you want to try it out
mxfb-keybindings-230909.tar

Re: Settings: Keybindings

Posted: Sat Sep 09, 2023 1:27 pm
by Jerry3904
That looks much better! Let me give it some testing and look closely at the source file b/c I made a number of changes for me table that I thought might be an improvement.

Re: Settings: Keybindings

Posted: Sat Sep 09, 2023 2:26 pm
by siamhie
Jerry3904 wrote: Sat Sep 09, 2023 12:23 pm Sure. But as I wrote in the top post in this thread: 1) we like to keep the default panel uncluttered, and 2) the keys file is not an easy read.

OK. Will this eventually change the menu entry for the keys file?

Code: Select all

[exec] (Keys) {exo-open ~/.fluxbox/keys}

Re: Settings: Keybindings

Posted: Sat Sep 09, 2023 2:38 pm
by Jerry3904
I think not.

Re: Settings: Keybindings

Posted: Sat Sep 09, 2023 5:03 pm
by Jerry3904
@Melber I've spent some time on your terrific rewrite--it works very well and looks much nicer.

I looked long and hard at the GUI and went through the code. I incorporated my changes into the attached file, and include a diff file so you can see what I've altered.
quickshot_230909_165516.png
My changes include:
--correction (e.g. of the keys file itself: move does not need, or work with, the Alt)
--text revision (TEXT1)
--text format (e.g., use of bold on tabs)
--clarification (e.g., replacing "KP" with "on keypad" inside the first column)
--simplification (e.g., removing clusters of letters/numbers) << I find them unnecessary, confusing and difficult to translate
--minor code change (e.g., adding a "gettext" to TEXT1).

Hope this is useful--see what you think.

Re: Settings: Keybindings

Posted: Sun Sep 10, 2023 10:52 am
by ceeslans
That sure looks great !
It would be great if the script could read the fluxbox 'keys' file and extract its current keybindings. That would also add value to the "Edit keys file" button; as it is right now, any alteration to the keys file will outdate the current yad script...

I do realize that similar manual editing would be required when using conky; but this is something that most users could handle. Would suggest to run such conky in a window - and to create a toggle in tint2 (and yes: or in ~/fluxbox/keys if you like) using a simple toggle script.
Below is an example of such 'keysbox' conky, depicting most (not all) keybindings in use on my system. Many deviating combo's - but trust you get the picture

Image

Re: Settings: Keybindings

Posted: Sun Sep 10, 2023 11:22 am
by Jerry3904
Some good ideas there, thanks.

My own preference would be to finish this first as it is now so we can get it quickly into users' hands, and then explore a new version.

Re: Settings: Keybindings

Posted: Mon Sep 11, 2023 6:57 pm
by Melber
@Jerry3904
Thanks for the corrections.
I have split up the text a bit to remove the markup notation from the translation strings. (TEXT2 still has the underline markup because I didn't want to break up the sentence).

Do you have any more changes?
mxfb-keybindings.tar

ceeslans wrote: Sun Sep 10, 2023 10:52 am It would be great if the script could read the fluxbox 'keys' file and extract its current keybindings. That would also add value to the "Edit keys
Yep, that would be great, buuut...need more time to figure it out..
eg. To open terminal default keys file has Ctrl Mod1 t :Exec roxterm
How do we find out if user edits this to Ctrl Mod1 f :Exec funkynewterminal

Re: Settings: Keybindings

Posted: Mon Sep 11, 2023 7:41 pm
by siamhie
Melber wrote: Mon Sep 11, 2023 6:57 pm Yep, that would be great, buuut...need more time to figure it out..
eg. To open terminal default keys file has Ctrl Mod1 t :Exec roxterm
How do we find out if user edits this to Ctrl Mod1 f :Exec funkynewterminal

@Melber Very true. I've modified my keys file to my liking.

Code: Select all

# open terminal
Ctrl Mod1 t :Exec xfce4-terminal

I know I'm an exception because I know my way around fluxbox (in general) but for the new user it would have to be universal.

Re: Settings: Keybindings

Posted: Mon Sep 11, 2023 8:46 pm
by Jerry3904
Do you have any more changes
Nope, looks done to me. Good work over there!

Re: Settings: Keybindings

Posted: Tue Sep 12, 2023 2:16 pm
by ceeslans
Melber wrote: Mon Sep 11, 2023 6:57 pm
ceeslans wrote: Sun Sep 10, 2023 10:52 am It would be great if the script could read the fluxbox 'keys' file and extract its current keybindings. That would also add value to the "Edit keys
Yep, that would be great, buuut...need more time to figure it out..
eg. To open terminal default keys file has Ctrl Mod1 t :Exec roxterm
How do we find out if user edits this to Ctrl Mod1 f :Exec funkynewterminal
Melber, please don't misunderstand me, I really do like your yad app, it's clean, to the point and smart looking. But I feel I wasn't wrong when I stated that any change to the fluxbox keys file, would automatically outdate the keybindings script. And yes, that statement will just as much apply to the 'conky-in-window' solution: both will display incorrect data - unless its code is brought up-to-date by the user. Haaa, I wonder how many users would open and update its respective script or conkyrc, maybe one out of ten, probably less. But changing the script will prove more of a hurdle than updating the conkyrc.

That said, let's try to come up with a way to have the mxfb-keybindings script source the fluxbox keys file.
Note that I'm not proficient in coding, mostly scraping/borrowing/stealing code snippets from others to create my own. So you will need to see what you could use and translate into sourcing code.
- first the fluxbox keys file needs to be more uniform in key-names, ie following actual names on the keyboard (when ever possible of course). For example, use Alt instead of mod1, and use Ctrl instead of Control
- use exclamation mark (!) to exclude comments from reading by the script. The hash sign (#) also does the job, but exclamation mark is the native 'exclude' sign in fluxbox config files.
- use the at sign (@) to describe the action (fluxbox seems to skip processing lines starting with the @ sign). That should allow you to distract the descriptive line for the first column
- use the uncommented line to distract the key-bindings, to go into the second column (but of course after excluding the second part starting with :Exec - can this be done with 'sed'?)

Again: I have no idea whether this would be viable - or even possible. You devs may now better.
Below a screenshot with the 'conky' version with the exact same data as the mxfb-keybindings script. It also shows geany texteditor with opened fluxbox keys file, so you get a better understanding of my suggested changes

Re: Settings: Keybindings

Posted: Tue Sep 12, 2023 5:12 pm
by Jerry3904
I have to confess that I don't see the point of travelling this road. The app just completed here is aimed at beginners, people who don't know about shortcuts at all, wouldn't know where to find them and have trouble figuring out the syntax and vocabulary of the file itself. Someone who has already gone into the keys file, by contrast, knows about shortcuts, can easily find them and has usually changed some of them to her/his liking so is familiar with words and syntax.

IMO, the first group needs our app (and our time), the second does not. I think we have more important work to do.

Re: Settings: Keybindings

Posted: Tue Sep 12, 2023 7:14 pm
by Melber
@ceeslans No offence taken, I get where you're coming from.
Making wholsesale changes to the keys file is not a good idea, stuff in home folder shouldn't get nuked by an update.
There's also no need, I've already got a test script working that can read the settings from the keys file as it is, as long as it knows what to look for. But, as I said above, the issue is knowing what to look for - searching for roxterm doesn't work if the user has changed the config to launch xfce4-terminal or one of the x million other terminals. There will be a solution, but I need to think about it and try out a few things.
For now the app seems to fulfil Jerry's requirements, so lets just consider it a first step...

@Jerry3904 What is the next step? Upload to mxfb-accessories? Translation?

Still haven't decided on a icon. Any preference?
mxfb-keybindings-1.png
mxfb-keybindings-2.png
mxfb-keybindings-3.png

Re: Settings: Keybindings

Posted: Tue Sep 12, 2023 7:26 pm
by Jerry3904
Upload to mxfb-accessories? Translation?
Yes and yes. Do you have access to Transifex (I do not)? If no, we can ask DO to handle it when he has a chance. The Settings file will need to be edited as well to include it.

Icon: I guess my preference would be #3 because of it simplicity. But you probably have a better sense of these things than I do...

Re: Settings: Keybindings

Posted: Tue Sep 12, 2023 7:30 pm
by Jerry3904
BTW: that use of roxterm was just because xfce4-terminal wouldn't stay put in the center, no matter what I did.

You wouldn't need to specify which one the user had decided on, since you could just use "Terminal" and be done with it. Likewise with "Editor," "Browser, etc.

Re: Settings: Keybindings

Posted: Tue Sep 12, 2023 8:05 pm
by Melber
OK, will try and make a PR in the next few days. Kinda busy atm and for the next few weeks.
I also wanted to make a couple of small adjustments to font and look if we're going to make a new accessories package...

Re: Settings: Keybindings

Posted: Tue Sep 12, 2023 8:44 pm
by Jerry3904
That's fine, I'm in no hurry. I will be leaving the country in a couple of days for 2+ weeks without my laptop so won't be able to do anything about it anyway.

We should get the translations going ASAP though, even if you have code changes to make, because I believe they are finished..

Re: Settings: Keybindings

Posted: Wed Sep 13, 2023 5:53 pm
by Melber
PR made to mxfb-accessories.
@Jerry3904 I included a .desktop file with empty translations. Maybe a post asking for translations in the translations forum?
@dolphin_oracle I have no idea how to upload the script to transifex for translation. Could you upload it when you have time?

Re: Settings: Keybindings

Posted: Wed Sep 13, 2023 11:16 pm
by dolphin_oracle
Melber wrote: Wed Sep 13, 2023 5:53 pm PR made to mxfb-accessories.
@Jerry3904 I included a .desktop file with empty translations. Maybe a post asking for translations in the translations forum?
@dolphin_oracle I have no idea how to upload the script to transifex for translation. Could you upload it when you have time?
if you put the name and comment strings in the script, then we can get the translations for the desktop file from that. easier that way

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 5:51 am
by Jerry3904
dolphin_oracle wrote: Wed Sep 13, 2023 11:16 pm <...>
if you put the name and comment strings in the script, then we can get the translations for the desktop file from that. easier that way
Thanks. I'm reviewing now, will do that and get it up before I leave.
--Any problem if I update the mxfb-settings.list as well to include this, and add mxfb-keybindings as a dependency?
--I guess this will be for MX-23 only, since some of those bindings are new.

@Melber OK with you if I change the desktop file name to "Shortcuts"? That's what will show up in Settngs manager and the change will match the others in there. (File name will remain mxfb-keybindings, as you have it.)

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 7:03 am
by Jerry3904
@Melber I just saw your question on Slack, so will wait for an updated script from you.

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 7:14 am
by dolphin_oracle
@Jerry3904 since the new script is in the mxfb-accessories git repo, I just assumed the script would be part of that package. If that's the case, then no need to add a depend because it will come with the package anyway.

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 7:21 am
by Melber
@Jerry3904 Do you mean rename mxfb-keybindings.desktop to shortcuts.desktop or just to change Name=Shortcuts in the .desktop file?

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 7:24 am
by dolphin_oracle
please review this area, as it seems to me many things do not need translated.

Code: Select all

#Translator Note#
#Please keep translated strings as short as possible#
#to avoid messing up the formatting#

LINE_1B_1="$(gettext 'Manual - MX Fluxbox')"
LINE_1B_2="$(gettext 'Ctrl F1')"
LINE_1C_1="$(gettext 'Manual - MX Linux')"
LINE_1C_2="$(gettext 'Shift F1')"
LINE_1D_1="$(gettext 'MX-Tools')"
LINE_1D_2="$(gettext 'Ctrl F5')"
LINE_1E_1="$(gettext 'Screen Magnifier')"
LINE_1E_2="$(gettext 'Ctrl Alt M')"
LINE_1F_1="$(gettext 'Next Workspace')"
LINE_1F_2="$(gettext 'Scroll Wheel Up')"
LINE_1F_3="$(gettext '   or')"
LINE_1F_4="$(gettext 'Ctrl Alt ')"
LINE_1G_1="$(gettext 'Previous Workspace')"
LINE_1G_2="$(gettext 'Scroll Wheel Down')"
LINE_1G_3="$(gettext '   or')"
LINE_1G_4="$(gettext 'Ctrl Alt ')"
also the non-ascii characters throw up some errors for the translation stuff.

I'm pushing up a couple of changes to the setup, but not the app itself. So be sure to sync up your git repos before doing anything.

also, please add the translator comments on lines just before strings that are to be translated. the blanket comment in the script will never be seen unless the script is opened up. so one string, on comment.

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 7:53 am
by Jerry3904
Melber wrote: Thu Sep 14, 2023 7:21 am @Jerry3904 Do you mean rename mxfb-keybindings.desktop to shortcuts.desktop or just to change Name=Shortcuts in the .desktop file?
Just Name=Shortcuts in the file, thanks

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 7:54 am
by Melber
dolphin_oracle wrote: Thu Sep 14, 2023 7:24 am please review this area, as it seems to me many things do not need translated.
translation required for every line in German at least

Code: Select all

LINE_1B_1="$(gettext 'Manual - MX Fluxbox')" 	> Handbuch - MX Fluxbox
LINE_1B_2="$(gettext 'Ctrl F1')" 		> Strg F1
LINE_1C_1="$(gettext 'Manual - MX Linux')" 	> Handbuch - MX Linux
LINE_1C_2="$(gettext 'Shift F1')" 		> Umschalt F1
LINE_1D_1="$(gettext 'MX-Tools')"		> MX-Werkzeuge
LINE_1D_2="$(gettext 'Ctrl F5')" 		> Strg F5
LINE_1E_1="$(gettext 'Screen Magnifier')" 	> Bildschirmlupe
LINE_1E_2="$(gettext 'Ctrl Alt M')" 		> Strg Alt M
LINE_1F_1="$(gettext 'Next Workspace')" 	> nächste Arbeitsfläche
LINE_1F_2="$(gettext 'Scroll Wheel Up')" 	> Mausrad nach oben
LINE_1F_3="$(gettext '   or')"			> oder
LINE_1F_4="$(gettext 'Ctrl Alt ')" 		> Strg Alt 
LINE_1G_1="$(gettext 'Previous Workspace')" 	> vorherige Arbeitsfläche
LINE_1G_2="$(gettext 'Scroll Wheel Down')" 	> Mausrad nach unten
LINE_1G_3=$(gettext '   or')" 			> oder
LINE_1G_4="$(gettext 'Ctrl Alt ')" 		> Strg Alt 

also the non-ascii characters throw up some errors for the translation stuff.
better like this?

Code: Select all

LINE_1E_2="$(gettext 'Ctrl Alt')M"
...
LINE_1F_4="$(gettext 'Ctrl Alt')"

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 7:56 am
by Jerry3904
dolphin_oracle wrote: Thu Sep 14, 2023 7:14 am @Jerry3904 since the new script is in the mxfb-accessories git repo, I just assumed the script would be part of that package. If that's the case, then no need to add a depend because it will come with the package anyway.
Ok, good. And you will be able to restrict mxfb-keybindings to MX-23 or later, right?

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 7:58 am
by dolphin_oracle
having never seen a german keyboard, I presume then that "cntrl" and "alt" need translated?

which brings up a point, what about "F*" keys? I don't know what those look like in other languages, or how fluxbox works with other keyboards, but its worth checking. especially for slavic or non-european languages.

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 8:02 am
by dolphin_oracle
Jerry3904 wrote: Thu Sep 14, 2023 7:56 am
dolphin_oracle wrote: Thu Sep 14, 2023 7:14 am @Jerry3904 since the new script is in the mxfb-accessories git repo, I just assumed the script would be part of that package. If that's the case, then no need to add a depend because it will come with the package anyway.
Ok, good. And you will be able to restrict mxfb-keybindings to MX-23 or later, right?
the package is already split for mx23.

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 8:46 am
by Jerry3904
Thanks

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 9:48 am
by Melber
dolphin_oracle wrote: Thu Sep 14, 2023 7:58 am having never seen a german keyboard, I presume then that "cntrl" and "alt" need translated?
Ctrl > Strg
Shift > Umschalt
Del > Entf
Maybe it's only German that relabels the keys?


Have made a new PR with updated script and desktop file

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 11:11 am
by Jerry3904
I just made a PR for mxfb-accessories with updates to mxfb-settings.list and help_mxfb-screensaver

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 11:17 am
by dolphin_oracle
Melber wrote: Thu Sep 14, 2023 9:48 am
dolphin_oracle wrote: Thu Sep 14, 2023 7:58 am having never seen a german keyboard, I presume then that "cntrl" and "alt" need translated?
Ctrl > Strg
Shift > Umschalt
Del > Entf
Maybe it's only German that relabels the keys?


Have made a new PR with updated script and desktop file
if they need relabeled they need relabeled. I have no idea, I have zero experience.

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 11:26 am
by dolphin_oracle
would the "left logo" key not be more commonly called "Super" ?

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 11:31 am
by dolphin_oracle
for the comment, instead of "commonly used" wouldn't these actually be "default shortcuts"?

I pushed up some changes for the comments, to illustrate sending instructions to the translators. I didn't do them all, just one block.

I think all the text at the top could be condensed some if using "default" rather than "common" everywhere. doesn't require the explainer that way.

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 12:22 pm
by Jerry3904
Nope. The keys shown in the app represent the intersection of the set of default keys with the set of common keys. I.e., the user may have common keys that are not default, and there are many default keys that are not common.

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 12:33 pm
by Jerry3904
dolphin_oracle wrote: Thu Sep 14, 2023 11:26 am would the "left logo" key not be more commonly called "Super" ?
Lemme think. "Left logo" is the code used in the Keys file. "Left" is needed b/c L logo and R logo are separate commands. "Logo" alternatives I have seen are "Super" and "Windows (Logo)." I left logo b/c I thought it was clear enough and reflected exactly the config file, but I have no problem with "Super" if that seems better to you.

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 1:01 pm
by Jerry3904
dolphin_oracle wrote: Thu Sep 14, 2023 11:17 am
Melber wrote: Thu Sep 14, 2023 9:48 am
dolphin_oracle wrote: Thu Sep 14, 2023 7:58 am having never seen a german keyboard, I presume then that "cntrl" and "alt" need translated?
Ctrl > Strg
Shift > Umschalt
Del > Entf
Maybe it's only German that relabels the keys?


Have made a new PR with updated script and desktop file
if they need relabeled they need relabeled. I have no idea, I have zero experience.
@Melber That may be the name, and other languages may have specialized names as well. But wouldn't every single computer user in the world (I exaggerate for emphasis) understand Ctrl. etc.?

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 1:34 pm
by dolphin_oracle
Jerry3904 wrote: Thu Sep 14, 2023 12:22 pm Nope. The keys shown in the app represent the intersection of the set of default keys with the set of common keys. I.e., the user may have common keys that are not default, and there are many default keys that are not common.
that is a very confusing sentence.

from the app
"'Changes made since installation will not be reflected in this app."

so it seems to me that you are displaying default keys, or at least "mx-fluxbox" default keys. If you are displaying keys that aren't set up, that would be confusing, and you are stating that changes to the keys file won't be reflected in app. So I can't see it as anything other than "defaults".

but what-evs.

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 1:38 pm
by Jerry3904
Sorry. Short and simple: there are many default keys that are not being shown because they are not frequently used.

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 1:40 pm
by Jerry3904
Or are impossibly complicated...

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 1:42 pm
by dolphin_oracle
ksnip_20230914-134147.jpg
all I know is when half the UI is taken up with disclaimer and explainer, something can be tweaked to make it better.

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 2:23 pm
by Jerry3904
I'll look at simplifying. Maybe all we need to do is add the word "default" in front of "shortcuts" in the top sentence.

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 4:15 pm
by Melber
Jerry3904 wrote: Thu Sep 14, 2023 1:01 pm @Melber That may be the name, and other languages may have specialized names as well. But wouldn't every single computer user in the world (I exaggerate for emphasis) understand Ctrl. etc.?
No, not in my experience.

I find it strange to translate an overview of keyboard shortcuts and then not translate what is actually printed on the keys of the keyboard itself.

MS too apparently
https://support.microsoft.com/de-de/wi ... 706c75eec

Re: Settings: Keybindings

Posted: Thu Sep 14, 2023 4:30 pm
by Jerry3904
OK, thanks. We'll leave those strings in, then.

Re: Settings: Keybindings

Posted: Fri Sep 15, 2023 7:11 am
by Jerry3904
Throwing in the towel: I think DO is right and that a single string should be displayed at the top:

Code: Select all

TEXT1="$(gettext 'This tool displays default shortcuts ("keys") that are frequently used.')"[\code]Please adjust so that a single word is not left hanging like that, if possible.

Re: Settings: Keybindings

Posted: Fri Sep 15, 2023 7:41 am
by Melber
@dolphin_oracle Are changes still okay or have the strings already been uploaded to transifex ?
Haven't got around to adding the additional translator comments yet...

@Jerry3904, presuming it's not too late.
- Will make the window a bit wider to try and get TEXT1 all on one line.
- The window title is currently Common MX-Fluxbox Keybindings. Are you happy with that or should it be changed to something else, eg. MXFB Default Shortcuts ?

Re: Settings: Keybindings

Posted: Fri Sep 15, 2023 8:39 am
by Jerry3904
Not critical, but I would now reduce it to "MX-Fluxbox Keybindings" so as not to repeat info in TEXT1

Re: Settings: Keybindings

Posted: Fri Sep 15, 2023 10:13 am
by dolphin_oracle
I have not uploaded any strings yet.

Re: Settings: Keybindings

Posted: Fri Sep 15, 2023 12:02 pm
by Melber
dolphin_oracle wrote: Fri Sep 15, 2023 10:13 am I have not uploaded any strings yet.
New PR with updated strings and translator comments

Re: Settings: Keybindings

Posted: Sat Sep 16, 2023 7:05 am
by i_ri
hello
match /usr/bin/mxfb-tiles (?)

Re: Settings: Keybindings

Posted: Sat Sep 16, 2023 8:02 am
by Jerry3904
This ship has sailed, but thanks--we'll review everything next time.

Re: Settings: Keybindings

Posted: Sat Sep 16, 2023 8:32 am
by dolphin_oracle
Melber wrote: Fri Sep 15, 2023 12:02 pm
dolphin_oracle wrote: Fri Sep 15, 2023 10:13 am I have not uploaded any strings yet.
New PR with updated strings and translator comments
Sorry I’ve been extremely sick. I’ll try to get this up today.

Re: Settings: Keybindings

Posted: Sat Sep 16, 2023 9:00 am
by Melber
No rush. Get better first.

Re: Settings: Keybindings

Posted: Sat Sep 16, 2023 9:32 am
by dolphin_oracle
suggestion:

"This tool displays frequently used default keyboard shortcuts"

Re: Settings: Keybindings

Posted: Sat Sep 16, 2023 9:40 am
by Jerry3904
I considered that but thought it's might be harder for translators. But I'll leave it up to you two.

Re: Settings: Keybindings

Posted: Sat Sep 16, 2023 9:47 am
by Melber
I have no horse in the race...

Re: Settings: Keybindings

Posted: Sat Sep 16, 2023 9:48 am
by dolphin_oracle
melber is anything going to break if those () and quotes are in there?

**edit** doesn't look like it. I'll send as is.