MX Package Installer has a difficulty writing file in /tmp [Solved]

[Adrian]

I seem to have a question that is supposed to pop up of mx_version >= 19 and of x86_64, doesn't this work?

Code: Select all

    // For 64-bit OS check if user wants AHS repo
    if (mx_version >= 19 && shell->getOut("uname -m", true) == "x86_64") {
        if (QMessageBox::Yes
            == QMessageBox::question(this, tr("Enabling AHS"), tr("Do you use AHS (Advanced Hardware Stack) repo?"))) {
            shell->runAsRoot(R"(sed -i '/^\s*#*\s*deb.*ahs\s*/s/^#*\s*//' /etc/apt/sources.list.d/mx.list)", true);
        }
    }

[fehlix]

I seem to have a question that is supposed to pop up of mx_version >= 19 and of x86_64, doesn't this work?

Code: Select all

    // For 64-bit OS check if user wants AHS repo
    if (mx_version >= 19 && shell->getOut("uname -m", true) == "x86_64") {
        if (QMessageBox::Yes
            == QMessageBox::question(this, tr("Enabling AHS"), tr("Do you use AHS (Advanced Hardware Stack) repo?"))) {
            shell->runAsRoot(R"(sed -i '/^\s*#*\s*deb.*ahs\s*/s/^#*\s*//' /etc/apt/sources.list.d/mx.list)", true);
        }
    }

Not if I have an empty or otherwise completely messed up mx.list. So “reset” should reset and not rely on what crap is currently in mx.list
+++EDIT+++
Or, at least if _ahs_ was detected no need to ask further.

[Adrian]

That's prompted after the list is restored, user is prompted to enable it or not... since the detection seem unreliable I think in the seldom cases people need to restore their sources they should be able to respond to a simple question if they want or not to enable AHS sources.

[fehlix]

That's prompted after the list is restored, user is prompted to enable it or not... since the detection seem unreliable I think in the seldom cases people need to restore their sources they should be able to respond to a simple question if they want or not to enable AHS sources.

Not needed if ahs is detected.
Try it: Reset, and enable ahs. Now reset again. Why do you want bother people to ask whether they want ahs, if ahs is clearly detected already?
Also the detection of ahs is very reliable apt's print-uris will tell, and clearly lists identfied components like ahs as such, and no network required to query.

[Adrian]

@fehlix I pushed the change to the repo https://github.com/MX-Linux/mx-repo-man ... 050358eb43

[fehlix]

@fehlix I pushed the change to the repo https://github.com/MX-Linux/mx-repo-man ... 050358eb43

maybe, the ahs-check and enabling the ahs-deb line, would be better done on the extracted mx.list within the tempdir
- before the move - otherwise after moving orig mx.list the ahs-check always fails - and ahs would be kept disabled.

[Adrian]

You just said:

the detection of ahs is very reliable apt's print-uris will tell, and clearly lists identfied components like ahs as such, and no network required to query.

Which is which...

[fehlix]

You just said:

the detection of ahs is very reliable apt's print-uris will tell, and clearly lists identfied components like ahs as such, and no network required to query.

Which is which...

I'll have a look .. there is something else ...

[fehlix]

OK, now with some more "fixes" , so it will handle existing double slashes when changing repos (I know localize-repo is now fixed - but anyway) also only prompts for AHS repo, if not already detected it is in use or not, i.e. only in cases user removed mx.list or completely commented out all lines, or otherwise no mx-repo was enabled.
Send PR @Adrian