GUI file converter app and its commands

Here is where you can post tips and tricks to share with other users of MX. Do not ask for help in this Forum.
Message
Author
SwampRabbit
Posts: 3602
Joined: Tue Jun 14, 2016 2:02 pm

Re: GUI file converter app and its commands

#31 Post by SwampRabbit »

Ok boss, I'll do the Pull Request (PR) in the morning, bed time for me :needcoffee:

There really is no right of wrong way, I'm probably the last person to teach you Git and GitHub stuff :killcomputer:
NEW USERS START HERE FAQS, MX Manual, and How to Break Your System - Don't use Ubuntu PPAs! Always post your Quick System Info (QSI) when asking for help.

TimothySimon
Posts: 93
Joined: Fri Sep 10, 2021 2:16 am

Re: GUI file converter app and its commands

#32 Post by TimothySimon »

SwampRabbit wrote: Tue Sep 21, 2021 1:10 am Ok boss, I'll do the Pull Request (PR) in the morning, bed time for me :needcoffee:

There really is no right of wrong way, I'm probably the last person to teach you Git and GitHub stuff :killcomputer:
Can you please do the PR now ? (I'm excited what a PR looks like) :happy:

SwampRabbit
Posts: 3602
Joined: Tue Jun 14, 2016 2:02 pm

Re: GUI file converter app and its commands

#33 Post by SwampRabbit »

TimothySimon wrote: Tue Sep 21, 2021 1:19 am Can you please do the PR now ? (I'm excited what a PR looks like) :happy:
Because you asked nice, and you’re doing a lot of work… yes. Just let me get back to the computer.
NEW USERS START HERE FAQS, MX Manual, and How to Break Your System - Don't use Ubuntu PPAs! Always post your Quick System Info (QSI) when asking for help.

SwampRabbit
Posts: 3602
Joined: Tue Jun 14, 2016 2:02 pm

Re: GUI file converter app and its commands

#34 Post by SwampRabbit »

@TimothySimon you should see the Pull Request (PR) now
NEW USERS START HERE FAQS, MX Manual, and How to Break Your System - Don't use Ubuntu PPAs! Always post your Quick System Info (QSI) when asking for help.

TimothySimon
Posts: 93
Joined: Fri Sep 10, 2021 2:16 am

Re: GUI file converter app and its commands

#35 Post by TimothySimon »

Yes. But I'm not getting how to "merge" it (sorry for my inexperience).

EDIT: Now, I have merged the pull request successfully.

TimothySimon
Posts: 93
Joined: Fri Sep 10, 2021 2:16 am

Re: GUI file converter app and its commands

#36 Post by TimothySimon »

SwampRabbit wrote: Tue Sep 21, 2021 12:15 am - you might want to hunt down an icon to use specifically for file-converter, using update notifier one can be confusing at least those that use it on MX. MAYBE... someone here on the forums would be interested in making you an icon?
Done (got an icon online).
SwampRabbit wrote: Tue Sep 21, 2021 12:15 am - you have some inconsistency of using then not using the "=" equal sign sometimes, I don't know if was affecting some of the tweaks I was trying to do to get the some of the below working or not. Maybe just go back and make sure some of your dialog items are correct and working as expected.
Already done in your PR.
SwampRabbit wrote: Tue Sep 21, 2021 12:15 am - on the dialog showing how many files will be converted and for selecting the converted output, if you previously didn't drop any files in it tells you to run it again, then both the cancel and ok buttons just close everything out... one might expect one of them, at least the ok button to take you back to the Drag N Drop dialog. Kinda a pain to open the application again
Done.
SwampRabbit wrote: Tue Sep 21, 2021 12:15 am - on the last dialog showing success of conversion, I think you should have a "Close" button and "View" button rather than "Cancel" and "Ok"
Done.
SwampRabbit wrote: Tue Sep 21, 2021 12:15 am - I tried to get the --image with --image-on-top to work so you could have a download icon image dead center of the dialog, but wouldn't work for some reason.... this kinda goes back to the previous item

- it would be nice to have some sort of notification that files have been dropped, maybe if even visual count in the dialog (see screenshot), its kinda hard to visually see its working initially and it might help first time users a bit
I don't know how to do these ( Please help.... )

SwampRabbit
Posts: 3602
Joined: Tue Jun 14, 2016 2:02 pm

Re: GUI file converter app and its commands

#37 Post by SwampRabbit »

You know you don't have to work so fast right? You can take your time. :p

The new icon looks nice. One thing about using icons or pictures found online, make sure they are free to use, also you want to reference or provide attribution to the person who created it if you can. A link to the where you got the icon is a good start if anything.

I'll take a look at the development branch in its current state first chance I get, but I have real world work to do, and lots of little MX things to do.

I couldn't get the --image-on-top to work myself, not sure why it doesn't work, but can mess with it some more at some point.
I had previously looked at doing this or having an image on top/under the dnd dialog for something else, but I never found a good solution to that.

As far as the dnd file count showing at the bottom of that main dialog, I tried to use the same file count you use for the next dialog after you click OK on the first, but something wasn't right and it wouldn't display which is why I didn't add it in that PR.

Neither of those suggestions are show stoppers, the application works really well from what I tested.

Keep up the awesome work, this is going to be useful for many users!
NEW USERS START HERE FAQS, MX Manual, and How to Break Your System - Don't use Ubuntu PPAs! Always post your Quick System Info (QSI) when asking for help.

User avatar
CharlesV
Administrator
Posts: 8170
Joined: Sun Jul 07, 2019 5:11 pm

Re: GUI file converter app and its commands

#38 Post by CharlesV »

@TimothySimon Hey went to download the latest and a) see your progress and b) do some conversion and its toss'n an error at me.

./file-converter-script.sh: 8: ./file-converter-script.sh: Syntax error: Bad function name

This was downloaded from github this am and into a fresh folder. Once I get some coffee in me I will take another look. (and could be me without any coffee too ;-p )
*QSI = Quick System Info from menu (Copy for Forum)
*MXPI = MX Package Installer
*Please check the solved checkbox on the post that solved it.
*Linux -This is the way!

User avatar
CharlesV
Administrator
Posts: 8170
Joined: Sun Jul 07, 2019 5:11 pm

Re: GUI file converter app and its commands

#39 Post by CharlesV »

Ya.. tis me on no coffee .. Was trying to run the wrong script ;-p .. duh !

Very nice ! Great job on this and it is already saving me a bunch of time on pulling some charts out of PDF's !!
*QSI = Quick System Info from menu (Copy for Forum)
*MXPI = MX Package Installer
*Please check the solved checkbox on the post that solved it.
*Linux -This is the way!

TimothySimon
Posts: 93
Joined: Fri Sep 10, 2021 2:16 am

Re: GUI file converter app and its commands

#40 Post by TimothySimon »

CharlesV wrote: Tue Sep 21, 2021 10:47 am Very nice ! Great job on this and it is already saving me a bunch of time on pulling some charts out of PDF's !!
Thank you ! :happy:

The latest (development -- unstable) scripts are at https://github.com/TimothySimon123/file ... evelopment
The latest stable ones are at https://github.com/TimothySimon123/file-converter

Post Reply

Return to “Tips & Tricks by users (not for help)”