
There really is no right of wrong way, I'm probably the last person to teach you Git and GitHub stuff

Can you please do the PR now ? (I'm excited what a PR looks like)SwampRabbit wrote: Tue Sep 21, 2021 1:10 am Ok boss, I'll do the Pull Request (PR) in the morning, bed time for me![]()
There really is no right of wrong way, I'm probably the last person to teach you Git and GitHub stuff![]()
Because you asked nice, and you’re doing a lot of work… yes. Just let me get back to the computer.TimothySimon wrote: Tue Sep 21, 2021 1:19 am Can you please do the PR now ? (I'm excited what a PR looks like)![]()
Done (got an icon online).SwampRabbit wrote: Tue Sep 21, 2021 12:15 am - you might want to hunt down an icon to use specifically for file-converter, using update notifier one can be confusing at least those that use it on MX. MAYBE... someone here on the forums would be interested in making you an icon?
Already done in your PR.SwampRabbit wrote: Tue Sep 21, 2021 12:15 am - you have some inconsistency of using then not using the "=" equal sign sometimes, I don't know if was affecting some of the tweaks I was trying to do to get the some of the below working or not. Maybe just go back and make sure some of your dialog items are correct and working as expected.
Done.SwampRabbit wrote: Tue Sep 21, 2021 12:15 am - on the dialog showing how many files will be converted and for selecting the converted output, if you previously didn't drop any files in it tells you to run it again, then both the cancel and ok buttons just close everything out... one might expect one of them, at least the ok button to take you back to the Drag N Drop dialog. Kinda a pain to open the application again
Done.SwampRabbit wrote: Tue Sep 21, 2021 12:15 am - on the last dialog showing success of conversion, I think you should have a "Close" button and "View" button rather than "Cancel" and "Ok"
I don't know how to do these ( Please help.... )SwampRabbit wrote: Tue Sep 21, 2021 12:15 am - I tried to get the --image with --image-on-top to work so you could have a download icon image dead center of the dialog, but wouldn't work for some reason.... this kinda goes back to the previous item
- it would be nice to have some sort of notification that files have been dropped, maybe if even visual count in the dialog (see screenshot), its kinda hard to visually see its working initially and it might help first time users a bit
Thank you !CharlesV wrote: Tue Sep 21, 2021 10:47 am Very nice ! Great job on this and it is already saving me a bunch of time on pulling some charts out of PDF's !!