OK, thanks. I was mentioning in case you want to avoid the install-python script,django013 wrote: Mon Feb 03, 2025 9:53 amI thought already doing this.but maybe you consider to move that "setup" logic into
a lua-function e.g. named like circle_setup(), where you re-formulate the python-logic into this lua-function,
and populate a "global" setup-table.
conky.arcs.lua starts with:... and generated config.lua looks like this:Code: Select all
cfg = require 'config' settings = cfg.setup()
and function conky_main then uses global table "settings"Code: Select all
local config = {} function config.setup() return { ... } end return config
to put all the detection work into a one-time running function,
you could then probably consider to use "lua_startup_hook".
Currently the global setup table is populated during lua_load,
which is fine, b/c that's a "static" table, which was genrated externaly with the python-script. But as I understood, they
introduced the "lua_startup_hook" to provide one spot, where all heavy loading/detection stuff can be run.
The point I mentioned was to use hwmon calls instead of lua-read-temp.django013 wrote: Mon Feb 03, 2025 9:53 ammay be I don't understand the point, you're leading me to.Maybe explain this issue, so somone can follow.which is the same for all nvme-sensors.Code: Select all
$ cat /sys/class/hwmon/hwmon0/name nvme
... andso from device's subdirectory I take the "real" name of the sensorCode: Select all
$ ll /sys/class/hwmon/hwmon0/device/ insgesamt 0 drwxr-xr-x 10 root root 0 3. Feb 14:08 nvme1n1 ...
Ahh, so the "issue" you mentioned was to combine the device "name" for those sensor types like "nvme".
and display the device name. OK, now I understand.
Also I tested you latest one, so seems you prefer to show temp with decimal places, which show here up to three decimals,
so you now can watch the temps in milleCentis. I could only avoid those decimals by letting conky get the temp with a ${hwmon ...} call.
Performance wise, probably not a big difference using lua-call or a hwmon-call, but still assume the compiled in hwmon call
is a bit faster then the lua-read-temp call.
Maybe final note: I really like the whole thing, but remember, MX is providing snapshot feature, and creation of
LiveUSBs, and it would be really nice if your conky would include a internal setup, instead requiring re-installation/re-setup,
when running on different systems. b/c when you move around onto another system,
with eg. LiveUSB or a personal Snapshot-ISO booted with Ventoy or a normally installed
on external removal drives. Or even only on internal installed system, I had the effect
the nvme's got different names depending whether I boot different different kernel. Can't remember
which one caused it. I was testing different things with both sysVinit and systemd and differernt liquorix and normal debian kernels,
where suddenly the nvme swapped the names.
And as you current conky is only prepared for the current running system after a re-setup/re-install.
Actually this would also be a show stopper for potentially getting this conky as it is currently setup, into a the MX collection of offered conky's.
So all is prepared by you. Great! May be you can find a way to move the python-setup stuff into the lua-setup-run-at-start thing.
Thanks